feat(relay): merge config with recorded provenance - #3587
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3645a9ced9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PR #3587 — feat(relay): merge config with recorded provenance
SummaryReworks relay/bench (and shared
FindingsBlockersNone for the PR alone (CI green, mergeable). Risks
Nits
CI
VerdictApprove (logic + tests look solid), but sequence after or rebase onto #3582 if both ship, and call out the env>file ops break in the merge note. |
merge round-trips through TOML and drops #[serde(skip)] fields. keep_parse_only restored only client_tls, so --auth-public-subscribe, --auth-public-publish, and --auth-public-api vanished and the relay started as though authentication were empty. File provenance now maps bench [client] keys onto connect.* so source() records the file origin. SNI cert helpers compile only for the backends that call them, which default-feature clippy requires after the noq default. Co-Authored-By: grok-4.6 <noreply@x.ai>
3645a9c to
65e41bf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65e41bf51c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
origin/dev's wasm-bindgen-cli is 0.2.127; the crate was still pinned to 0.2.121, so wasm-bindgen refused the bindgen format. Co-Authored-By: grok-4.6 <noreply@x.ai>
#3587 made stats.enabled a bool, so the construction-time cache test cannot wrap it in Some. Co-Authored-By: grok-4.6 <noreply@x.ai>
1 participant
Summary
moq-relayandmoq-benchmerge CLI, env, and TOML with recorded provenance. Presence comes fromCliLayer/EnvLayer/ the file, never from whether a standing value looks empty, so a file that sets[]orfalsesurvives.moq_tokio::cli::merge. Env now outranks the file.setting = "dotted.key"on Args plus a matchingusage::Configfield;Registry::drifttests they stay in step.Option<bool>merge workaround forstats.enabled,runtime.pin,runtime.io_uring,web.ws, andcluster.lan.enabled.Closes #3051
Closes #3221
Public API
Breaking:
StatsConfig.enabled,RuntimeConfig.pin,RuntimeConfig.io_uring,WebConfig.ws,LanConfig.enabled:Option<bool>tobool.usage::Clithat flattens a group withsetting=needs#[usage(settings)].Additive:
moq_tokio::cli::mergeandmoq_tokio::cli::FileSource.moq_relay::Config::sourceand benchConfig::source.moq_tokio::settings(doc hidden).Wire
None.
(written by grok-4.6)