chore: bump crate versions by hand - #384
Merged
Merged
Conversation
Replaces the release-plz proposal in #363. Two of its minor bumps were driven only by `auto_trait_impl_removed`, which is not a break worth a major-equivalent version here: no name, signature, or behavior changed, and a caller that was relying on `UnwindSafe` for one of these types was relying on an accident. - qmux 0.5.0 -> 0.5.1. The only flagged break is `Session`, `Stream`, and `Upgraded` losing `UnwindSafe`/`RefUnwindSafe`. `Session::stats()` gained RTT and delivery rate (#380), which is additive. - web-transport-quinn 0.12.0 -> 0.12.1. #369 touched this crate only to add the `harness-server` example; the library is unchanged. - web-transport-quiche 0.6.0 -> 0.7.0. Not unwind: #367 and #372 reverse the meaning of `SendStream::set_priority` and `ez::SendStream::set_priority` to higher-first. Same signature, opposite behavior, so a patch would silently invert send order for anyone who upgrades. - web-transport-wasm 0.5.10 -> 0.6.0. Also not unwind: `Error::Streams` is gone, `Error::Session` is now a struct variant, `Error::Closed` is new, and both `closed()` methods take `&mut self`. - web-transport 0.11.0 -> 0.12.0, following wasm, whose items it re-exports wholesale on wasm32. web-transport-proto stays at the 0.6.1 already in its manifest but not yet on crates.io. web-transport-ffi and web-transport-node need no bump at all: their `web-transport-quinn = "0.12"` requirement still matches 0.12.1, so the cascade that gave them 0.1.3 and 0.0.7 in #363 disappears. Also corrects the qmux README install snippet, which still said 0.4. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gokPRtDeLNb9vgWqdFqWh
kixelated
marked this pull request as ready for review
August 20, 2026 02:09
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Open
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
WalkthroughThe PR updates release metadata for ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the release-plz proposal in #363, which has to be closed for this to release.
Two of its minor bumps were driven only by
auto_trait_impl_removed. That is not a break worth a major-equivalent version here: no name, signature, or behavior changed, and a caller relying onUnwindSafefor one of these types was relying on an accident.Versions
qmuxweb-transport-quinnweb-transport-quicheset_priorityreverses meaningweb-transport-wasmErrorvariants,&mut selfreceiversweb-transportweb-transport-protoweb-transport-ffiweb-transport-quinn = "0.12"still matchesweb-transport-nodePatched instead of minor
qmux0.5.1 — the only flagged break isSession,Stream, andUpgradedlosingUnwindSafe/RefUnwindSafe.Session::stats()gaining RTT and delivery rate (#380) is additive.web-transport-quinn0.12.1 — #369 touched this crate only to add theharness-serverexample. The library is untouched, and cargo-semver-checks agreed it was compatible; release-plz proposed 0.13.0 because the commit carried a!.Dropping the quinn requirement change is what removes
web-transport-ffiandweb-transport-nodefrom the release entirely. Their"0.12"requirement is satisfied by 0.12.1, so #363's "updated the following local packages" bumps had nothing behind them.Kept minor
These are not unwind, so a patch would be a silent break for anyone who upgrades:
web-transport-quiche— fix(quiche): make set_priority higher-first across the crate #367 and refactor(quiche)!: move the priority inversion into ez #372 reverseSendStream::set_priorityandez::SendStream::set_priorityto higher-first. Same signature, opposite behavior; cargo-semver-checks cannot see it.web-transport-wasm—Error::Streamsis gone,Error::Sessionis now a struct variant,Error::Closedis new, andSendStream::closed/RecvStream::closedtake&mut self.web-transport—pub use quic::*re-exports the wasm module wholesale on wasm32, so theErrorchange lands in its surface too.Each is a one-line revert to a patch if you'd rather ship them that way.
Other
The
qmuxREADME install snippet still saidqmux = "0.4".Checks
Manifests and markdown only.
cargo metadata --no-depsresolves the workspace, and every intra-workspace path requirement is satisfied by the new versions (checked by hand — the nix shell isn't available in this environment, sojust checkwasn't run; there is no trackedCargo.lockto update).Generated by Claude Code