Apply auto-fixes to UPxxx formatting rules; update ignore list - #25390
Open
eviljeff wants to merge 1 commit into
Open
Apply auto-fixes to UPxxx formatting rules; update ignore list#25390eviljeff wants to merge 1 commit into
eviljeff wants to merge 1 commit into
Conversation
eviljeff
marked this pull request as ready for review
September 4, 2026 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on work for #25288
Description
Applies UPxxx rules that have auto-fixes available in ruff, and splits the ignore list into deliberate ignore rules, and ones we'll aim to use in the future (but we aren't right now because of the size of the diff)
Context
This is a little different to the other ruff-rule prs I've been creating recently - it's all safe
ruff check --fix, and no AI rewrites. (Although I did have to manually fix ~15 places where ruff had fixed it with lines that were too long 馃檮)The list of rules we deliberately ignore may increase as we see what the actual fixes need to be - I've only noticed ISC004 so far.
Testing
N/A, it's all auto-fixed stuff
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.