Don't check auto-approval restrictions for enterprise versions - #25413
Merged
Conversation
Skip the check entirely for enterprise: no flag, no history, no activity log.
diox
reviewed
Sep 9, 2026
Comment on lines
+582
to
+584
| if channel != amo.CHANNEL_ENTERPRISE: | ||
| checker = RestrictionChecker(upload=upload) | ||
| if not checker.is_auto_approval_allowed(): |
Member
There was a problem hiding this comment.
instantiating the RestrictionChecker is not costly, so I would replace that with:
checker = RestrictionChecker(upload=upload)
if channel != amo.CHANNEL_ENTERPRISE and not checker.is_auto_approval_allowed():And that way you don't have to introduce a new indentation level just for this...
Review feedback: as the RestrictionCheck is not costly, it's okay to fold it into the existing condition instead of adding an indentation level.
diox
approved these changes
Sep 9, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of mozilla/addons#16408
Context
While reviewing #25344, QA pulled up enterprise addons still passing the transparency check. It turns out this existed before the aforementioned PR.
Description
After this PR,
Version.from_upload()now skips the auto-approval restriction check entirely for enterprise-channel versions. Enterprise versions are exempt from the auto-approval-disabled flags anyway (AutoApprovalSummary.check_has_auto_approval_disabled()), so the check was recording a "disabled" that never applied — and, as a side effect, setting the unlisted flag on the add-on, since the flag selection predates the enterprise channel. Submission-type restrictions are unaffected.Testing
New test in
TestExtensionVersionFromUpload: a matching "Add-on Approval" restriction plus an enterprise submission.Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.