Add export.include_all for public types - #1182
Open
youknowone wants to merge 2 commits into
Open
Conversation
`export.include_all` appended the collected public type names to `config.export.include` after parsing. The roots now travel through a `public_types` field on `Parse` and `Library` instead, and `Library::generate` seeds them next to functions, globals and constants. `Library::add_root` holds the traversal shared with `export.include`. Recording a public type now requires `ParseConfig::should_generate_top_level_item`, the gate that functions, statics and constants already pass, so only the binding crate and `parse.extra_bindings` contribute. Types of other parsed crates are still emitted when an exported item depends on them. Assisted-by: Claude
youknowone
commented
Aug 31, 2026
Comment on lines
+495
to
+496
| fn record_public_type(&mut self, record: bool, vis: &syn::Visibility, path: &Path) { | ||
| if record && matches!(vis, syn::Visibility::Public(_)) { |
Contributor
Author
There was a problem hiding this comment.
I feed awkward that record_public_type and its callers have a parameter like record: bool, but didn't find good way not to do yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #605