Conversation
RJAK11
requested review from
freshstrangemusic,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
July 31, 2026 16:13
RJAK11
force-pushed
the
16582
branch
2 times, most recently
from
July 31, 2026 19:33
bf6ad44 to
d44bf9d
Compare
Because * we need sidebar controls for moving between set up and preview This commit * adds the set up control which unlocks the preview button once there are no setup issues * adds the preview controls to request enrollment or move back to set up * adds the review controls card allowing the launch approve/reject flow and the RS link and timeout message Fixes #16582
yashikakhurana
requested changes
Jul 31, 2026
yashikakhurana
left a comment
yashikakhurana
left a comment
Contributor
There was a problem hiding this comment.
In general good test coverage, workflow looks good, can you just change the color of approve and reject to green and red, that's easy to find for the approvers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #16582
Screen.Recording.2026-07-31.at.3.10.15.PM.mov