Conversation
moibra05
requested review from
RJAK11,
freshstrangemusic,
jaredlockhart,
mikewilli and
yashikakhurana
as code owners
July 31, 2026 20:10
yashikakhurana
requested changes
Jul 31, 2026
|
|
||
| class Meta: | ||
| model = NimbusBranchScreenshot | ||
| fields = ("image", "description") |
Contributor
There was a problem hiding this comment.
why this change here
| alert = NimbusAlert.objects.create( | ||
| experiment=experiment, | ||
| alert_type=NimbusConstants.AlertType.UPDATE_REQUEST, | ||
| message="⏩ Requests rollout phase advance", |
Contributor
There was a problem hiding this comment.
can we use the constants here that you have declared
| alert = NimbusAlert.objects.create( | ||
| experiment=experiment, | ||
| alert_type=NimbusConstants.AlertType.END_EXPERIMENT_REQUEST, | ||
| message="⏸️ Requests disable rollout", |
Contributor
There was a problem hiding this comment.
same here, and also in some other test cases to use the constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #16532