Shorten the handling of /A and /a page labels - #21814
Open
Snuffleupagus wants to merge 1 commit into
Open
Conversation
I happened to glance at this code, and noticed that using the style-value *itself* to compute the current character would shorten this code a little bit. Note that this particular page label format seems to be somewhat rarely used in practice, compared to e.g. the roman numerals format, which probably isn't that strange given its definition: https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G11.2096063
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 22, 2026 20:14 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21814 +/- ##
==========================================
- Coverage 90.20% 90.19% -0.01%
==========================================
Files 264 264
Lines 67339 67336 -3
==========================================
- Hits 60741 60733 -8
- Misses 6598 6603 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I happened to glance at this code, and noticed that using the style-value itself to compute the current character would shorten this code a little bit.
Note that this particular page label format seems to be somewhat rarely used in practice, compared to e.g. the roman numerals format, which probably isn't that strange given its definition: https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G11.2096063