webdav: add SCCACHE_WEBDAV_DISABLE_CREATE_DIR option - #2872
Merged
Merged
Conversation
sylvestre
reviewed
Sep 25, 2026
sylvestre
reviewed
Sep 25, 2026
sylvestre
reviewed
Sep 25, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2872 +/- ##
==========================================
+ Coverage 76.35% 76.40% +0.05%
==========================================
Files 72 72
Lines 40219 40250 +31
==========================================
+ Hits 30709 30754 +45
+ Misses 9510 9496 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ChriFo
force-pushed
the
webdav-disable-create-dir
branch
from
September 25, 2026 19:19
84a417f to
0ad20fe
Compare
Some WebDAV servers only implement GET/HEAD/PUT/DELETE and reject MKCOL with 405 Method Not Allowed, which makes every cache write fail since the webdav backend issues a MKCOL/PROPFIND before each write to ensure the parent directory exists. Sonatype Nexus raw repositories are one such server. opendal already supports skipping this (apache/opendal#7177, released in 0.56.0). Set SCCACHE_WEBDAV_DISABLE_CREATE_DIR=true to use it. This carries forward just the disable_create_dir part of #2591, which was closed over the git dependency on opendal that PR needed at the time; opendal 0.58.1, already used here, ships the option on crates.io, so no such dependency is needed anymore.
ChriFo
force-pushed
the
webdav-disable-create-dir
branch
from
September 25, 2026 19:24
0ad20fe to
ce20e23
Compare
Collaborator
|
if the ci is green i will merge it |
Collaborator
|
Thanks for your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the
disable_create_dirpart of #2591 (closed), split out per@weihanglo's suggestion there — see discussion on that PR.
Some WebDAV servers only implement GET/HEAD/PUT/DELETE and reject MKCOL
with 405 Method Not Allowed, which makes every cache write fail since the
webdav backend issues a MKCOL/PROPFIND before each write to ensure the
parent directory exists. Sonatype Nexus raw repositories (hosted, via
WebDAV) are one such server; I've been running this patch against one in
production.
opendal already supports skipping this (apache/opendal#7177), released in
0.56.0. sccache is already on opendal 0.58.1 (#2715), so this needs no git
dependency — just the config plumbing.