docs: rework the @include TIP to present both fragment-composition styles - #24
Merged
Conversation
…yles The previous TIP claimed the including template must never own the connecting `and`, arguing from the un-expanded template's raw-paste validity. But an @include-containing template is an authoring artifact; Expand produces the two-way SQL, so requiring the un-expanded form to run raw was too strict. Replace it with a TIP that presents both valid styles — (a) the fragment owns the leading `and` and the un-expanded template is itself runnable; (b) the fragment is self-contained with its own `1 = 1` anchor and the including template owns the `and`, valid after Expand — and lets the author choose. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YAydPGeSHjZvJv22oz4P6d
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 11 11
Lines 951 951
=======================================
Hits 918 918
Misses 21 21
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TIP added in #23 was too strict: it claimed the including template must never own the connecting
and, arguing from the un-expanded template's raw-paste validity. But an@include-containing template is an authoring artifact —Expandproduces the two-way SQL — so requiring the un-expanded form to run raw was not a real constraint.This replaces it with a TIP that presents both valid styles:
and, and the un-expanded template is itself runnable (where 1 = 1 /*%! @include */);1 = 1anchor) and the including template owns theand(where 1 = 1 and /*%! @include */), valid afterExpand.Both build to valid SQL; the author picks based on whether the un-expanded template should also run verbatim.
🤖 Generated with Claude Code