Skip to content

fix(studio): let the auto-join toggle show what it just saved #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroops0111 merged 1 commit into from
Sep 15, 2026
Merged

fix(studio): let the auto-join toggle show what it just saved #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/studio/src/components/WorkspaceDetailsSheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,8 +866,12 @@ function MembersSection({ workspaceId }: { workspaceId: string }) {
const policy = useWorkspacePolicy(workspaceId)
const canManageMembers = policy.can('workspace.manage')

// Admitting everyone edits the workspace itself and backfills the list,
// so one such save leaves both of them stale,
// and the toggle below reads its own state from the workspace rather than here.
function invalidate() {
queryClient.invalidateQueries({ queryKey: queryKeys.workspaceMembers(workspaceId) })
queryClient.invalidateQueries({ queryKey: queryKeys.workspaces() })
}

if (isLoading) {
Expand Down Expand Up @@ -945,20 +949,24 @@ function AutoJoinControl({ workspaceId, onChanged }: {
})

return (
<div className="mt-3 flex items-start gap-2 border-t border-border pt-3">
// The size sits on the row, not on the two spans inside it.
// A label carries the strut of whatever it inherits,
// so a span cannot shrink the line box, and the box beside it
// ends up centred on a taller line than the one it can see.
<div className="mt-3 flex items-start gap-2 border-t border-border pt-3 text-2xs">
<input
type="checkbox"
id={`auto-join-${workspaceId}`}
checked={admitting}
disabled={save.isPending}
onChange={event => save.mutate(event.target.checked)}
className="mt-0.5 size-3 accent-primary"
className="mt-0.5 size-3 shrink-0 accent-primary"
/>
<label className="flex-1" htmlFor={`auto-join-${workspaceId}`}>
<span className="text-2xs font-medium text-foreground">
<label className="flex flex-1 flex-col gap-0.5" htmlFor={`auto-join-${workspaceId}`}>
<span className="font-medium text-foreground">
{t('workspace.details.autoJoinTitle')}
</span>
<span className="mt-0.5 block text-2xs leading-relaxed text-muted-foreground">
<span className="leading-relaxed text-muted-foreground">
{t('workspace.details.autoJoinHint')}
</span>
</label>
Expand Down
Loading