Fix display cadence refresh on monitor moves - #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #278.
Notes
GitHub #278 is accurate for the reported build/logs where driver vsync could be treated as the sole cadence owner. On current master, present_should_wall_pace() already runs a wall-clock deadline cap even when driver vsync owns cadence, so this stale-display bug should not produce unbounded 200% RT there. The remaining current-master bug is stale display identity/refresh causing stale swap/present mode and a host-adjusted effective period until the runtime is restarted.
Test
Build verification