Skip to content

Triage #403 findings: close replay-protection test gap, defer/redirect the rest to scoped issues #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muke1908 merged 1 commit into from
Aug 29, 2026
Merged

Triage #403 findings: close replay-protection test gap, defer/redirect the rest to scoped issues #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions service/src/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,78 @@ describe('receiving chat-message', () => {
});
});

// ---------------------------------------------------------------------------
// receiving a webrtc signal
// ---------------------------------------------------------------------------
describe('receiving webrtc signal', () => {
it('decrypts the envelope and delivers it to call-invite subscribers', async () => {
const instance = await buildInitializedInstance();
await instance.setChannel(ROOM_ID, SECRET, USER_ID);
const cb = jest.fn();
instance.on('call-invite', cb);

const envelope = await sealWithDefaultStrategy('signaling', { type: 'call-invite', callId: 'call-1', seq: 1, timestamp: 1 });

wireHandlerFor('webrtc-session-description')({ envelope });
await flushAsync();

expect(cb).toHaveBeenCalledWith(expect.objectContaining({ callId: 'call-1' }));
});

it('drops a replayed/duplicate signal (same sequence number twice for the same call)', async () => {
const instance = await buildInitializedInstance();
await instance.setChannel(ROOM_ID, SECRET, USER_ID);
const cb = jest.fn();
instance.on('call-invite', cb);

const envelope = await sealWithDefaultStrategy('signaling', { type: 'call-invite', callId: 'call-1', seq: 5, timestamp: 1 });
const handler = wireHandlerFor('webrtc-session-description');

handler({ envelope });
await flushAsync();
handler({ envelope });
await flushAsync();

expect(cb).toHaveBeenCalledTimes(1);
});

it('drops an out-of-order/lower sequence number signal for the same call', async () => {
const instance = await buildInitializedInstance();
await instance.setChannel(ROOM_ID, SECRET, USER_ID);
const cb = jest.fn();
instance.on('call-invite', cb);
const handler = wireHandlerFor('webrtc-session-description');

const newer = await sealWithDefaultStrategy('signaling', { type: 'call-invite', callId: 'call-1', seq: 5, timestamp: 1 });
const older = await sealWithDefaultStrategy('signaling', { type: 'call-invite', callId: 'call-1', seq: 3, timestamp: 1 });

handler({ envelope: newer });
await flushAsync();
handler({ envelope: older });
await flushAsync();

expect(cb).toHaveBeenCalledTimes(1);
});

it('does not drop a signal for a different call id, even with a lower/equal sequence number', async () => {
const instance = await buildInitializedInstance();
await instance.setChannel(ROOM_ID, SECRET, USER_ID);
const cb = jest.fn();
instance.on('call-invite', cb);
const handler = wireHandlerFor('webrtc-session-description');

const callOne = await sealWithDefaultStrategy('signaling', { type: 'call-invite', callId: 'call-1', seq: 5, timestamp: 1 });
const callTwo = await sealWithDefaultStrategy('signaling', { type: 'call-invite', callId: 'call-2', seq: 1, timestamp: 1 });

handler({ envelope: callOne });
await flushAsync();
handler({ envelope: callTwo });
await flushAsync();

expect(cb).toHaveBeenCalledTimes(2);
});
});

// ---------------------------------------------------------------------------
// createChatInstance() encryption strategy selection
// ---------------------------------------------------------------------------
Expand Down