gtk: load status icons as pixbufs again - #273
Merged
Merged
Conversation
When we switched to icon name based rendering in PR#257 we forgot to consider the following case: the gtk CellRenderer always looks up the icon with GTK_ICON_LOOKUP_GENERIC_FALLBACK. Our icons are called package-* and shipped in the hicolor theme. However on systems that do not have the "hicolor" theme but a different scheme with an icon named "package" the fallback logic will use that for everything we call "package-*" as it assumes its a better icon then using a more specific name but from a different icon theme. This commit fixes the issue by partly reverting the changes from PR#257 and moves back to precise icon name rendering without fallbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we switched to icon name based rendering in PR#257 we forgot to consider the following case: the gtk CellRenderer always looks up the icon with GTK_ICON_LOOKUP_GENERIC_FALLBACK. Our icons are called package-* and shipped in the hicolor theme. However on systems that do not have the "hicolor" theme but a different scheme with an icon named "package" the fallback logic will use that for everything we call "package-*" as it assumes its a better icon then using a more specific name but from a different icon theme.
This commit fixes the issue by partly reverting the changes from PR#257 and moves back to precise icon name rendering without fallbacks.