Migrate Kyper AttentionFilled Icon to MXUI - #356
Open
mwclemy wants to merge 10 commits into
Open
Conversation
mwclemy
requested review from
Jameson13B,
ash-wright123,
codingLogan and
wesrisenmay-mx
as code owners
July 29, 2026 18:16
platypus801
reviewed
Jul 30, 2026
platypus801
reviewed
Jul 30, 2026
platypus801
reviewed
Jul 30, 2026
platypus801
reviewed
Jul 30, 2026
Collaborator
|
@mwclemy it looks like the warning symbol changed from grey to black. Is that intentional? |
| <AttentionFilled color="#4D4D4D" size={32} style={styles.errorIcon} /> | ||
| <Text component={'h2'} style={styles.errorTitle} truncate={false} variant="H2"> | ||
| <div className={styles.container}> | ||
| <Icon fill={true} name="error" size={32} sx={{ mb: 3 }} /> |
Collaborator
There was a problem hiding this comment.
It looks like we're using margins to put space between things. Lets use a stack with spacing.
| display: flex; | ||
| flex-direction: column; | ||
| width: 100%; | ||
| margin-top: var(--spacing-large); |
Collaborator
There was a problem hiding this comment.
Same deal for all of this. Let's use a stack with spacing to create gaps between things.
| data-test="disconnect-button" | ||
| onClick={handleOnDisconnect} | ||
| sx={styles.button} | ||
| sx={{ mt: 2.5, mb: 1 }} |
Collaborator
There was a problem hiding this comment.
Stacks with spacing
| <Stack | ||
| alignItems="center" | ||
| justifyContent="center" | ||
| sx={{ |
Collaborator
There was a problem hiding this comment.
Use css modules instead of sx
| dangerouslySetInnerHTML={{ __html: sanitizedInstructionalText }} | ||
| data-test="instructional_text" | ||
| sx={{ marginBottom: tokens.Spacing.XSmall, ...style }} | ||
| sx={{ marginBottom: 1, ...style }} |
Collaborator
There was a problem hiding this comment.
css modules instead of sx
| sx={{ | ||
| marginTop: 16, | ||
| marginBottom: 32, | ||
| marginTop: 2, |
Collaborator
There was a problem hiding this comment.
css modules instead of sx
| @@ -0,0 +1,10 @@ | |||
| :root { | |||
| --spacing-xtiny: 2px; | |||
Collaborator
There was a problem hiding this comment.
These aren't mui things right? We made these up?
| border-style: solid; | ||
| border-width: 2px; | ||
| border-radius: 100%; | ||
| font-size: 18px; |
Collaborator
There was a problem hiding this comment.
I'm skeptical that we should be customizing the font size of an MXUI component. @platypus801?
| } | ||
|
|
||
| .paragraph:global(.MuiTypography-root) { | ||
| margin-bottom: var(--spacing-xlarge); |
| className={styles.badge} | ||
| color="error" | ||
| sx={(theme) => ({ | ||
| '& .MuiBadge-badge': { borderColor: theme.palette.common.white }, |
Collaborator
There was a problem hiding this comment.
css modules instead of sx
| onClick={handleSubmit} | ||
| sx={{ | ||
| marginBottom: tokens.Spacing.XSmall, | ||
| marginBottom: 1, |
Collaborator
There was a problem hiding this comment.
css modules instead of sx
| justifyContent: 'space-between', | ||
| padding: '0 0 16px 0', | ||
| marginTop: tokens.Spacing.XSmall, | ||
| marginTop: '1px', |
Collaborator
There was a problem hiding this comment.
Stacks for spacing. Do we really want a 1px margin? @platypus801
| return ( | ||
| <> | ||
| <Text bold={true} component="h2" sx={{ mb: 12 }} truncate={false} variant="H2"> | ||
| <Text bold={true} component="h2" sx={{ mb: 1.5 }} truncate={false} variant="H2"> |
Collaborator
There was a problem hiding this comment.
Stacks for spacing
| <div style={styles.container}> | ||
| <div style={styles.iconContainer}> | ||
| <AttentionFilled color={tokens.Color.NeutralWhite} size={24} /> | ||
| <Icon fill={true} name="error" size={24} sx={{ color: 'common.white' }} /> |
Collaborator
There was a problem hiding this comment.
css modules instead of sx
| data-test="verify-existing-member-header" | ||
| id="connect-select-institution" | ||
| sx={{ marginBottom: tokens.Spacing.Small }} | ||
| sx={{ marginBottom: 1.5 }} |
| component="h3" | ||
| data-test="connected-institutions-text" | ||
| sx={{ marginBottom: tokens.Spacing.Tiny, fontWeight: 600 }} | ||
| sx={{ marginBottom: 0.5, fontWeight: 600 }} |
Collaborator
There was a problem hiding this comment.
Stacks for spacing. css modules instead of sx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before(Kyper)
After(MXUI)