Repository navigation
chore(ci): Use the common workflow for min-crates - #4505
Merged
Merged
Conversation
We need to start deduplicating all these workflows. The min-crates one was designed explicitly as a copy of the iroh one, so we can now start sharing this. The major change is that we don't use pick-runner for the windows machine right now. I could add it but it would run *next* to the pick-runner-windows that is in tests.yaml. Which defeats the point a bit. I guess the full fix is to move pick-runner(-windows) into ci.yaml and pass it's result into tests.yaml somehow. But for now I think the simple thing of not using an overflow runner is probably fine.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4505/docs/iroh/ Last updated: 2026-10-01T14:05:41Z |
Arqu
approved these changes
Sep 5, 2026
flub
added a commit
to n0-computer/workflows
that referenced
this pull request
Sep 28, 2026
See n0-computer/iroh#4515. This edited a file that's being deleted in n0-computer/iroh#4505
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to start deduplicating all these workflows. The min-crates one
was designed explicitly as a copy of the iroh one, so we can now start
sharing this.
The major change is that we don't use pick-runner for the windows
machine right now. I could add it but it would run next to the
pick-runner-windows that is in tests.yaml. Which defeats the point a
bit. I guess the full fix is to move pick-runner(-windows) into
ci.yaml and pass it's result into tests.yaml somehow.
But for now I think the simple thing of not using an overflow runner
is probably fine.
Breaking Changes
n/a
Notes & open questions
n/a
Change checklist
proposed change and wrote an as clear and concise description as
they could.
intented effect.