Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4572.
RelayTransport::poll_recvindexed output slots by receive attempts. Dropping an oversized batch could leave a gap, causing the caller to miss a later usable message. If every attempt dropped data, the poll could also returnPendingwithout requesting a wake for traffic still in the queue.This change:
bufs,metas, andrecv_infosbynum_msgs, keeping usable outputs contiguous after drops.continueinstead ofbreakafter dropping an oversized single datagram.cx.waker().wake_by_ref()when message drops exhaust thebufs.len()attempt limit, ensuring another poll.API Changes
None.
Notes & open questions
The regression tests use 1,472-byte receive buffers and cover both oversized batches and oversized single datagrams:
These tests replace the narrower oversized-batch progress test.
Change checklist
proposed change and wrote as clear and concise a description as
they could.
intended effect.