Skip to content

Migrate .runsettings for Unit Test projects - #406

Merged
josesimoes merged 1 commit into
nanoframework:mainfrom
josesimoes:fix-unit-tests
Jul 10, 2026
Merged

Migrate .runsettings for Unit Test projects#406
josesimoes merged 1 commit into
nanoframework:mainfrom
josesimoes:fix-unit-tests

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • Moved next to solution file.
  • Remove from all unit test projects.
  • Addded to solution itens.

Motivation and Context

  • Migrate to moder pattern of having a global .runsettings file close to the solution file.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Moved next to solution file.
- Remove from all unit test projects.
- Addded to solution itens.
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ff38d5b5-6ec0-4e31-a637-c013b0ab8830

📥 Commits

Reviewing files that changed from the base of the PR and between 5e70b87 and 3543635.

📒 Files selected for processing (7)
  • .runsettings
  • Tests/IPAddressTests/IPAddressTests.nfproj
  • Tests/NetworkHelperTests/NetworkHelperTests.nfproj
  • Tests/NetworkHelperTests/nano.runsettings
  • Tests/SocketTests/SocketTests.nfproj
  • Tests/SocketTests/nano.runsettings
  • nanoFramework.System.Net.sln
💤 Files with no reviewable changes (2)
  • Tests/NetworkHelperTests/nano.runsettings
  • Tests/SocketTests/nano.runsettings

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Consolidated test execution settings at the solution level for more consistent runs.
    • Reduced the test session timeout to improve feedback when tests become unresponsive.
    • Updated the configured device connection port for hardware-based testing.
    • Removed outdated, project-specific test settings that could cause inconsistent configuration across test projects.

Walkthrough

The solution centralizes nanoFramework test settings in the root .runsettings file, updates the session timeout and serial port, and removes local runsettings references and files from network test projects.

Changes

Test settings configuration

Layer / File(s) Summary
Central runsettings configuration
.runsettings, nanoFramework.System.Net.sln
The solution exposes the root settings file, which changes the test session timeout from 120000 ms to 60000 ms and the device port from COM3 to COM9.
Project-local settings removal
Tests/IPAddressTests/IPAddressTests.nfproj, Tests/NetworkHelperTests/NetworkHelperTests.nfproj, Tests/SocketTests/SocketTests.nfproj, Tests/NetworkHelperTests/nano.runsettings, Tests/SocketTests/nano.runsettings
The test projects no longer reference local nano.runsettings files, and the NetworkHelper and Socket local settings files are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: Area: Config-and-Build

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the runsettings migration for unit test projects and matches the PR changes.
Description check ✅ Passed The description is directly related to moving .runsettings to the solution and removing it from individual test projects.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@josesimoes
josesimoes merged commit 826fa6c into nanoframework:main Jul 10, 2026
8 checks passed
@josesimoes
josesimoes deleted the fix-unit-tests branch July 10, 2026 10:49
josesimoes added a commit that referenced this pull request Jul 13, 2026
***NO_CI***

(cherry picked from commit 826fa6c)
@coderabbitai coderabbitai Bot mentioned this pull request Jul 17, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants