test: pin first-visit task cards and Sign in click-through - #464
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: pin first-visit task cards and Sign in click-through#464cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
#463 made the homepage task cards and canvas/welcome Sign in the first-click path, but those handlers only ran in the optional Playwright smoke. An EXAMPLES slug rename would silently no-op a task card, and a dropped click-through would leave Sign in dead. Co-authored-by: mikkel <mikkel@255bits.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
nanoodle | 845f9c4 | Commit Preview URL Branch Preview URL |
Sep 05 2026, 10:18 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
#463 made the homepage “Start with a task” cards and the canvas / shared-app Sign in buttons the first-click path. Those handlers only ran in
smoke-first-run.mjs, which is a separate Chromium workflow and is not in the regularcheck-*.mjssuite. A gallery slug rename (common on EXAMPLES sync) makes a task card a silent no-op (findIndex === -1). A dropped#hintsignin/#recwelcome-signinclick-through leaves the new Sign in CTA dead. A signed-inrenderAuththat forgets to hide those pitches sends people around OAuth again.#463 already pinned the money path (
mdlDEMO_CTX vs paid drift, starter/gallery catalog fixtures). This PR covers the remaining first-click wiring.Test files added/updated
scripts/check-onboarding.mjs(new).githooks/pre-commit(run the check when index/play/the issue form change)Pins, offline, zero API spend (real handlers in node:vm):
#exampletasksdata-example-slugresolves to anEXAMPLESentry; at least three cards stay present.loadExample(i)for a match and ignores an unknown slug.#hintsigninand play#recwelcome-signinclick through to#signin.renderAuthhides#hintauth/#hintsampleonce a key is stored; play builderrenderAuthhides#recwelcome-signin.share-workflow.yml(requiredshare_linkfield), not built-with-nanoodle.Why these tests materially reduce regression risk
First-click onboarding is how a new NanoGPT user reaches a runnable workflow. The Playwright smoke is optional and environment-dependent; this check runs in CI and pre-commit with no browser. Losing slug lockstep, or the Sign in click-through, is a dead homepage with every other paid-path guard still green.
node scripts/check-onboarding.mjsis green. No production behavior change.