chore(deps): allow better-sqlite3 13 as a peer (0.5.1) - #32
Merged
Conversation
Isolated major-version review, matching the one done for @nest-native/jobs. better-sqlite3 13 is an N-API rewrite: its JavaScript surface is purely additive (db.explain(), statement.toString()) with no removals, and SqliteError still carries the `code` the inbox's exactly-once dedup keys on — verified SQLITE_CONSTRAINT_UNIQUE on 13.0.2. The full suite (135 tests), 100% coverage, typecheck, and both sample smokes (showcase + Kafka) pass against 13.0.2. The range is WIDENED, not moved: better-sqlite3 13 requires Node >=22 while this package still supports Node >=20, so the devDependency stays on 12.x and the Node-20 CI legs keep installing. A new CI leg installs 13 on Node 22 and runs the suite there, so both ends of the published peer range are tested rather than assumed; the guidelines record that rule. Behaviorally unchanged — this only lets consumers on Node 22+ upgrade their own better-sqlite3 without an npm ERESOLVE. Together with jobs 0.2.1 it unblocks nest-native/reference-app#69.
📊
|
| Metric | PR | Base | Diff | |
|---|---|---|---|---|
| Statements | ████████████████████ |
2070/2070 (100%) |
2070/2070 (100%) |
⚪ 0% |
| Branches | ████████████████████ |
279/279 (100%) |
279/279 (100%) |
⚪ 0% |
| Functions | ████████████████████ |
88/88 (100%) |
88/88 (100%) |
⚪ 0% |
| Lines | ████████████████████ |
2070/2070 (100%) |
2070/2070 (100%) |
⚪ 0% |
Updated for 149d3e1 | Compared against base branch
⏱️ Performance Report
🐢 Slowest test suites
🐌 Slowest individual tests
Updated for |
🧠 Cognitive Complexity Report
🧩 Most complex functions
Updated for |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolated major-version review: better-sqlite3 13
Widens the published peer range to
^11 || ^12 || ^13, matching nest-native/jobs#16 (released as 0.2.1). Both were needed: nest-native/reference-app#69 cannot install better-sqlite3 13 while either package's peer range rejects it (npmERESOLVE).What v13 actually changes
An N-API rewrite (prebuilt binaries ship with the package;
prebuild-installis gone). The JavaScript surface is purely additive —db.explain()andstatement.toString()added, nothing removed — plus aSqliteErrorcross-realm fix. Critically,SqliteErrorstill carries thecodethe inbox's exactly-once dedup keys on: verifiedSQLITE_CONSTRAINT_UNIQUEon 13.0.2.Verification (against 13.0.2, before widening)
typecheckclean ·release:checkcleanWhy widened, not moved
better-sqlite3 13 requires Node >=22; this package supports Node >=20. The devDependency therefore stays on 12.x — otherwise the Node-20 CI legs stop installing and a supported Node is silently dropped. A new CI leg (
better-sqlite3 13 compatibility (Node 22)) installs 13 and runs the suite there, so both ends of the range are tested. The guidelines now record that rule.This also means #29 (bumping the better-sqlite3 devDependency to 13) should be closed rather than merged — it would break the Node-20 legs.
Behaviorally unchanged, so a patch release: 0.5.1.