Skip to content

estimate_p_values_mc is prohibitively slow #368

Description

@katehoffshutta

Currently, p-value computation is done via the comparison of each entry in the partial correlation matrix to the empirical distribution in a vanilla way that takes quite some time (I would guess infeasible for more than ~100 predictors).

We have some algorithmic improvements, including parallelization, that need to be added so that this function is of practical use.

In the meantime, it would be good to also add a warning message to the code for users who try to run estimate_p_values_mc so that they aren't waiting a long time for results that are not going to appear in a reasonable time frame.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions