chore: remove nullain-search local-path workarounds - #79
Merged
Conversation
nullain-search 0.1.0 is now published on PyPI (https://pypi.org/project/nullain-search/). Removes both temporary workarounds this required: - pyproject.toml: tool.uv.sources no longer overrides nullain-search to the sibling repo's local path — nullain-sdk/pyproject.toml's search-rust extra constraint (nullain-search>=0.1.0,<0.2.0) resolves it from PyPI like any other dependency. - ci.yml: removes the extra checkout-and-move steps (6 jobs) that cloned netty-linux/nullain-sdk-search alongside this repo so `uv sync` could find the local path — no longer needed. - uv.lock: regenerated; nullain-search's entry now points at the PyPI registry with sdist/wheel hashes, no local path anywhere in the file. Verified in an isolated clone (no sibling repo present anywhere nearby): `uv sync --all-packages` resolves cleanly, and `pip install nullain-sdk[search-rust]` pulls the real wheel from PyPI and imports/runs correctly. `make check` passes both with the extra installed (14/14 search contract tests, both adapters) and without it (rust_search cases skip cleanly, web_search unaffected). Closes #77 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullain-search0.1.0 is published on PyPI — removes the two temporary workarounds tracked in Publicar nullain-search no PyPI e substituir tool.uv.sources por constraint de versão #77.pyproject.toml: drops thetool.uv.sourcesoverride pointing at the sibling repo's local path; only the version constraint innullain-sdk/pyproject.toml'ssearch-rustextra remains.ci.yml: removes the extra checkout-and-move steps (6 jobs) that clonednetty-linux/nullain-sdk-searchforuv syncto find locally.uv.lock: regenerated —nullain-search's entry now resolves from the PyPI registry with sdist/wheel hashes, no local path anywhere.Closes #77
Test plan
nullain-sdk-searchanywhere nearby;uv sync --all-packagesresolved cleanlyuv pip install nullain-sdk[search-rust]pulled the real wheel from PyPI andimport nullain_search/SearchIndexworkedmake check(ruff + pyright strict + pytest) green with thesearch-rustextra installed — 14/14 search contract tests pass against bothWebSearchProviderandRustSearchAdaptermake checkgreen without the extra installed —rust_searchcontract cases skip cleanly,web_searchunaffecteduv.lock—nullain-searchentry usessource = { registry = "https://pypi.org/simple" }, nopath/editablereference anywhere in the filenullain-sdk/src/nullain/__init__.py— zero lines changed🤖 Generated with Claude Code