Skip to content

NPS-D: update SAML settings screenshot for 26.09.0 - #1489

Open
TM-PO-Netwrix wants to merge 1 commit into
devfrom
tm-npsd
Open

NPS-D: update SAML settings screenshot for 26.09.0#1489
TM-PO-Netwrix wants to merge 1 commit into
devfrom
tm-npsd

Conversation

@TM-PO-Netwrix

Copy link
Copy Markdown
Contributor

Summary

  • Replace the SAML operational settings screenshot in samlsso.md with an updated version reflecting the NPS-D 26.09.0 UI

Test plan

  • Verify the new screenshot renders correctly on the SAML SSO page
  • Confirm build passes

Generated with AI

Co-Authored-By: Claude Code ai@netwrix.com

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Documentation PR Review

Editorial Review

docs/privilegesecurediscovery/2.22/administration/configuration/microsoftentraid/samlsso.md

  • Completeness — Line 113: The revised version note no longer identifies which NPS-D build the screenshot depicts. The previous wording told readers the image showed 26.06; now the image shows 26.09.0 but nothing says so. A reader running an earlier build sees an Auto-Redirect to IdP row in the screenshot that isn't in their UI, with no explanation. Suggested fix: "Version note: This screenshot shows NPS-D 26.09.0. Starting with NPS-D 26.09.0, the SAML/SSO Configuration section includes an Auto-Redirect to IdP row with the redirect to IdP on login page checkbox."
  • Clarity — Line 113: The note names the UI location as the SAML/SSO Configuration section, but step 1 of this procedure (line 90) sends the reader to Configure > Server > SAML Configuration. A reader can't tell whether these are the same screen or two different ones. Suggested fix: use one label consistently — either match the procedure with "the SAML Configuration page", or add the mapping once (for example, "the SAML Configuration page (SAML/SSO Configuration section)").
  • Structure — Line 113: The version note uses a Markdown blockquote, while the rest of the doc set uses Docusaurus admonitions for supplementary information. Since this line is already being rewritten, converting it keeps the callout styling consistent with other Netwrix pages. Suggested fix: replace the blockquote with :::note / ::: around the version note text.

Summary

3 editorial suggestions across 1 file. Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

0 issues fixed, 3 skipped across 1 files

Skipped (needs manual review) Reason

| docs/privilegesecurediscovery/2.22/administration/configuration/microsoftentraid/samlsso.md:150 — Dale: passive-voice | "The expected NPS-D identity is signed in." reads as a state description, and the surrounding bullets are parallel state checks ("is correct", "is on the final application route", "still works"). Any active rewrite would break that parallelism or shift the meaning. |
| docs/privilegesecurediscovery/2.22/administration/configuration/microsoftentraid/samlsso.md:117 — Dale: undefined-acronyms | IdP appears at lines 100-117 only inside literal UI control names ("Auto-Redirect to IdP", "force IdP reauthentication"), which must match the product interface verbatim. The acronym is spelled out as "identity provider (IdP)" at line 122. |
| docs/privilegesecurediscovery/2.22/administration/configuration/microsoftentraid/samlsso.md:183 — Dale: wordiness | "fails in a controlled manner" is slightly wordy, but it carries a specific acceptance-test meaning (graceful failure rather than any failure). No shorter alternative preserves that distinction. |

Ask @claude on this PR if you'd like an explanation of any fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant