fix(contextchat): use a consistent item id for indexed messages - #13443
Open
kesselb wants to merge 1 commit into
Open
fix(contextchat): use a consistent item id for indexed messages#13443kesselb wants to merge 1 commit into
kesselb wants to merge 1 commit into
Conversation
Contributor
Author
|
/backport to stable5.10 |
Content was indexed as "{mailboxId}:{messageId}" but deleted by bare
IMAP uid, so deleting a message never removed it from the knowledge
base. Key both sides off account, mailbox and uid via a shared helper.
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
# Conflicts:
# lib/ContextChat/ContextChatProvider.php
kesselb
force-pushed
the
fix/context-chat-item-id
branch
from
August 9, 2026 15:22
d190fbe to
7fadd20
Compare
Member
|
/backport to stable5.11 |
edward-ly
reviewed
Aug 10, 2026
edward-ly
left a comment
edward-ly
left a comment
Contributor
There was a problem hiding this comment.
Also roping in @marcelklehr for additional insight. I'll test this later if I have time, but it looks good to me so far. Do we need to do some sort of migration as well (e.g. updating the IDs of existing items, or deleting and re-importing all messages again)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content was indexed as "{mailboxId}:{messageId}" but deleted by bare IMAP uid, so deleting a message never removed it from the knowledge base. Key both sides off account, mailbox and uid via a shared helper.
馃 AI (if applicable)