fix(sync): reset #sending flag when no active connection on sendStepsNow#8796
Open
omnizs38 wants to merge 3 commits into
Open
fix(sync): reset #sending flag when no active connection on sendStepsNow#8796omnizs38 wants to merge 3 commits into
omnizs38 wants to merge 3 commits into
Conversation
Without this fix, a connection loss during step push setup leaves #sending permanently true. The sendSteps() interval checks !this.#sending before calling sendStepsNow(), so all subsequent local changes are silently dropped — never sent to the server — even after the connection recovers. Signed-off-by: omnizs38 <omnizs@proton.me>
omnizs38
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
mejo-
requested changes
Jul 9, 2026
mejo-
left a comment
mejo-
left a comment
Member
There was a problem hiding this comment.
@omnizs38 did you run into an actual bug that you're fixing here, or was it a random finding by AI?
The fix in SyncService.ts looks sensible to me. Do you agree @max-nextcloud?
| this.bus.emit('stateChange', { dirty: true }) | ||
| } | ||
| if (!this.hasActiveConnection()) { | ||
| this.#sending = false |
Member
There was a problem hiding this comment.
This looks like a sensible fix to me. We return early but don't rest this.#sending.
| const openResult = { connection, data: initialData } | ||
|
|
||
| describe('Sync service', () => { | ||
| it('resets #sending when there is no active connection', async () => { |
Member
There was a problem hiding this comment.
The test looks useless to me, I'd drop it.
Contributor
Author
There was a problem hiding this comment.
Okay, but I'm not at home right now. When I am, I'll definitely make some edits based on your suggestions. Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
When
sendStepsNow()is called without an active connection, it setsthis.#sending = trueand then returns early — but never resets the flag tofalse.The
sendSteps()interval guards its body with!this.#sending, so once this early-return path is hit, the interval fires forever butsendStepsNow()is never called again. All locally typed changes accumulate in the outbox and are silently never pushed to the server, even after the connection recovers resulting in data loss.Fix: reset
this.#sending = falsebefore the early return.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)