fix(redis): do not log the Redis password - #1316
Open
bakiburakogun wants to merge 1 commit into
Open
Conversation
The websocket server logs its Redis URL verbatim on every start, so a
deployment that authenticates to Redis writes the password into the journal
in clear text:
Creating Redis client with URL: redis://:s3cret@10.0.0.5:6379
Redact the credentials before logging. The host and port, which are what the
line is useful for, stay visible.
Signed-off-by: Baki Burak Öğün <63836730+bakiburakogun@users.noreply.github.com>
bakiburakogun
requested review from
grnd-alt,
hweihwang and
juliusknorr
as code owners
August 26, 2026 12:39
bakiburakogun
force-pushed
the
fix/redact-redis-credentials
branch
from
August 30, 2026 02:13
e578398 to
3e240e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
RedisAdapter.createRedisClient()logs the configured Redis URL verbatim every time the websocket server starts. On any deployment that authenticates to Redis, that writes the password into the journal in clear text:We hit this on a production install: the password we had just put in a
0600environment file showed up injournalctla second later, where it is readable by anyone who can read the journal and by whatever ships logs off the box.The change
Redact the credentials before logging. The host and port, which are the useful part of the line, stay visible:
A URL that cannot be parsed logs a placeholder rather than the raw string, so a malformed value with a secret in it does not leak either.
Testing