fix: preserve zero hyperframe durations#118
Conversation
PerishCode
left a comment
There was a problem hiding this comment.
@C1-BA-B1-F3 I reviewed the Hyperframes parser change and the new unit coverage for zero-duration values from both data-duration attributes and inline frame markers. The updated parser keeps explicit 0 values from falling through to the default duration, and I checked the Remotion export consumer path for compatibility. Nice focused fix with the right regression coverage.
|
Hey @C1-BA-B1-F3 — heads-up: PR #119 is also open in this area. Both PRs touch |
|
Thanks for the heads-up. I will defer to the maintainers on whether this PR or #119 is the cleaner path, and I am happy to adapt or close this one if they prefer the other approach. |
|
Thanks for the flexibility here, @C1-BA-B1-F3 — that makes the maintainer decision a lot easier. No action needed from you right now; we'll let the maintainers choose between #118 and #119, and if they want this one adjusted or closed they'll say so directly here. |
Summary
Tests