implement matthias recom, update to snaptshots and version bump.#194
Open
heylf wants to merge 3 commits into
Open
implement matthias recom, update to snaptshots and version bump.#194heylf wants to merge 3 commits into
heylf wants to merge 3 commits into
Conversation
mashehu
reviewed
Jul 23, 2026
mashehu
approved these changes
Jul 23, 2026
Collaborator
Author
|
I will update the module as well in a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit finalizes the 1.0.1 release and implements a review recommendation from Matthias regarding the
--expansion-distanceXeniumRanger parameter.Release finalization (1.0.1)
nextflow.config: pipeline version bumped from1.1.0devto1.0.1.assets/multiqc_config.yml: report links updated from thedevbranch/docs to the1.0.1release tag/docs.ro-crate-metadata.json:creativeWorkStatuschanged fromInProgresstoStable, version set to1.0.1, and the pipeline URL updated tohttps://nf-co.re/spatialaxe/1.0.1/.CHANGELOG.md: added a new1.0.1devsection header and finalized the1.0.1 - [date]section.New
expansion_distanceparameter (Matthias's recommendation)Previously,
--expansion-distancewas appended to XeniumRanger's arguments via a staticext.argsclosure inconf/modules.config, gated only onnucleiandparams.expansion_distance. This commit removes that closure and instead threadsexpansion_distanceas an explicit process/subworkflow input:modules/nf-core/xeniumranger/import-segmentation/main.nf: addedexpansion_distanceas a tuple input; the module now only emits--expansion-distance=<value>when a nuclei segmentation is being imported (XeniumRanger rejects the flag for transcript-assignment or cells-only imports).baysor_run_prior_segmentation_maskbaysor_run_transcripts_parquetbaysor_run_transcripts_parquet_tiledcellpose_baysor_import_segmentationcellpose_resolift_morphology_ome_tifproseg_preset_proseg2baysorproseg_preset_proseg2baysor_tiledsegger_create_train_predictstardist_resolift_morphology_ome_tifxeniumranger_import_segmentation_redefine_bundlexeniumranger_resegment_morphology_ome_tifworkflows/spatialaxe.nf: the top-level workflow now passesexpansion_distanceinto each of the above subworkflow calls.PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).