Corrected output of fixes. - #4
Open
dehain wants to merge 4 commits into
Open
Conversation
dehain
force-pushed
the
master
branch
2 times, most recently
from
February 25, 2018 19:56
ac1cbd0 to
e8520e3
Compare
Fixed indentation of line that was causing only the last fix to be displayed.
Added a parameter (--no-fetch) that specifies to not attempt fetching from the remote. This is useful in situations where there is no connectivity to the remote.
Added a parameter (--current-branch) that will use whatever the currently checked out branch is rather than requiring the branch to be specified or defaulting to master.
Changed error code when no results are found from returning (-1) to simply returning 0. I don't think that not finding results is an error and this is an issue when I use this script with another script that depends on the return code indicating success or failure.
niedbalski
reviewed
Jul 29, 2019
| if commit_date >= days_ago and \ | ||
| description_regex.search(message): | ||
| yield((message, commit_date, vcs.get_affected_files(id))) | ||
|
|
Owner
There was a problem hiding this comment.
There are trailing tabs/spaces on this code, can you correct those?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed indentation of line that was causing only the last fix to be
displayed.