Skip to content

Fix: include lts flag in per-event product_map so TestHub derives origin correctly - #61

Merged
shubhamkd merged 1 commit into
nightwatchjs:mainfrom
MihirR-BS:LTS-per-event-productmap-lts-flag-upstream
Aug 31, 2026
Merged

Fix: include lts flag in per-event product_map so TestHub derives origin correctly#61
shubhamkd merged 1 commit into
nightwatchjs:mainfrom
MihirR-BS:LTS-per-event-productmap-lts-flag-upstream

Conversation

@MihirR-BS

Copy link
Copy Markdown
Contributor

Summary

  • Build-create's product_map correctly carries `lts: true` when the session is Load Testing (see `getProductMapForBuildStartCall` in `src/testObservability.js` at ~line 1014), but the per-event send at `src/testObservability.js:529-532` (used for `TestRunStarted`/`TestRunFinished`) does not.
  • Without `lts: true` on the per-event product_map, TestHub's downstream `getOriginFromSource` returns `UnknownGrid` for the event, the error rows land with `error_cluster_id=NULL`, and the Load Testing product's Unique Errors panel renders empty even when the test actually failed.
  • Mirrors the equivalent Python SDK fix pattern.

Test plan

  • Nightwatch load test with a failing case — Unique Errors panel now populates (previously empty).
  • Non-LTS Nightwatch run unaffected — `isLoadTestingSession()` returns false, product_map.lts is `false`, no behavior change for regular Automate / Observability runs.

Build-create's product_map already carries lts=true (see
getProductMapForBuildStartCall at ~line 1014); the per-event TestRun /
HookRun send at line 529-532 did not. Without lts=true on the per-event
product_map, TestHub's getOriginFromSource returns UnknownGrid, the
error event lands with error_cluster_id=NULL, and the Load Testing
Unique Errors panel renders empty even when the test actually failed.

Mirrors the equivalent Python SDK fix pattern (PR #1194).
@shubhamkd
shubhamkd merged commit edb60d7 into nightwatchjs:main Aug 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants