Conversation
Invalid :ets_options and an unknown bucket are both caller mistakes, so ArgumentError is the accurate type. Code rescuing RuntimeError around Rkv.ets/1 needs updating. Also merges the two broadcast helpers into one, and returns :ok from delete/2 explicitly instead of relying on the helper's return value.
nmbrone
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid
:ets_optionsand an unknown bucket are both caller mistakes, soArgumentErroris the accurate type rather than a bareRuntimeError.Behaviour change: code rescuing
RuntimeErroraroundRkv.ets/1needs updating.