fix(esm): preserve circular re-export initialization - #291
Draft
BridgeAR wants to merge 2 commits into
Draft
Conversation
IITM replaces the native back-edge with an uninitialized wrapper binding when it wraps every edge in an ESM export-star cycle. Valid class initialization then fails before the hook runs. Generation-scoped cleanup prevents older concurrent resolutions from deleting newer cycle state. Fixes: #290 Signed-off-by: Ruben Bridgewater <ruben.bridgewater@datadoghq.com>
An async wrapper scan consumes its initiating parent before the scan finishes. A concurrent resolve then dereferences missing state. Ignoring that resolve leaves a cycle candidate that bypasses the next hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IITM replaces the native back-edge with an uninitialized wrapper binding when it wraps every edge in an ESM
export *cycle. Valid class initialization then fails before the hook runs.This keeps the matching static cycle edge unwrapped. Generation-scoped cleanup prevents older concurrent resolutions from deleting newer cycle state.
The ordinary 32,250-module path had no reproducible CPU or retained-heap regression. The active star graph used 2.22% less CPU and 0.42% more retained heap. Repeated cached imports measured 0.996x CPU and 0.908x retained heap versus
main.Fixes: #290