fs: fix glob early return skipping sibling entries

[semimikoh]

Summary

• Remove cache.seen check from children iteration loop in #addSubpatterns (sync) and #iterateSubpatterns (async)
• The return inside the loop exits the entire method, skipping all remaining siblings
• The cache.add at the top of each method already prevents reprocessing and infinite recursion

Fixes: #62897

Test plan

• Run test-fs-glob.mjs multiple times to verify flakiness is resolved
• Verify the reproduction script from the issue passes consistently

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (d080801) to head (4f3a919).
⚠️ Report is 903 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62901      +/-   ##
==========================================
- Coverage   91.55%   89.65%   -1.90%     
==========================================
  Files         355      708     +353     
  Lines      149381   220407   +71026     
  Branches    23364    42272   +18908     
==========================================
+ Hits       136765   197614   +60849     
- Misses      12354    14655    +2301     
- Partials      262     8138    +7876     

Files with missing lines	Coverage Δ
lib/internal/fs/glob.js	92.06% <ø> (+5.38%)	⬆️

... and 496 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72881/

[semimikoh]

@ZYSzys Could you re-run CI on this when you get a chance? 🙏

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/72881/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/27184867612

[semimikoh]

@ZYSzys could you run CI on this?

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/72881/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/28997064065

[webdevelopersrinu]

Hi @semimikoh, are you still working on this? It looks like CI hasn't passed and there's been no activity for a while. If you don't have time to continue, I'd be happy to take this over and finish the fix (with credit to your work here). Thanks!

[semimikoh]

@trivikr Sure, feel free to take it over and continue the work. Thanks!

[webdevelopersrinu]

Thanks @semimikoh Just to confirm I think you meant me (@webdevelopersrinu), as I'm the one who asked above 🙂. I'll take this over, keep your work credited with Co-authored-by, and open a PR with the fix + regression test + green CI.

[trivikr]

Superceded by #64895