Skip to content

deps: update histogram to 0.11.10#64296

Open
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/truetools-update-histogram
Open

deps: update histogram to 0.11.10#64296
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/truetools-update-histogram

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of histogram to 0.11.10.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jul 5, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 5, 2026
@aduh95

aduh95 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Related failure on Windows build:

lld-link : error : undefined symbol: __cpu_model [D:\a\node\node\node_mksnapshot.vcxproj]
  >>> referenced by D:\a\node\node\deps\histogram\src\hdr_histogram.c:777
  >>>               histogram.lib(hdr_histogram.obj):(hdr_value_at_percentile)

@StefanStojanovic

Copy link
Copy Markdown
Contributor

I was able to reproduce this locally and to fix it with this simple patch. While it can be patched here, landing this fix in the histogram repo is probably better in the long run.

@aduh95

aduh95 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Did you send the patch upstream? Once it’s landed there, we can cherry-pick it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants