Skip to content

deps: update c-ares to 1.34.7#64330

Open
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/truetools-update-c-ares
Open

deps: update c-ares to 1.34.7#64330
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/truetools-update-c-ares

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of c-ares to 1.34.7.

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. labels Jul 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 6, 2026
@aduh95

aduh95 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
../src/cares_wrap.cc:1740:3: error: no matching function for call to 'ares_gethostbyaddr'
 1740 |   ares_gethostbyaddr(wrap->channel()->cares_channel(),
      |   ^~~~~~~~~~~~~~~~~~
../deps/cares/include/ares.h:887:19: note: candidate function not viable: no overload of 'Callback' matching 'ares_host_callback' (aka 'void (*)(void *, int, int, const struct hostent *)') for 5th argument
  887 | CARES_EXTERN void ares_gethostbyaddr(ares_channel_t *channel, const void *addr,
      |                   ^
  888 |                                      int addrlen, int family,
  889 |                                      ares_host_callback callback, void *arg);
      |                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants