Skip to content

crypto: limit KangarooTwelveParams customization to 512 bytes#64557

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:limit-kt-customization
Open

crypto: limit KangarooTwelveParams customization to 512 bytes#64557
panva wants to merge 1 commit into
nodejs:mainfrom
panva:limit-kt-customization

Conversation

@panva

@panva panva commented Jul 17, 2026

Copy link
Copy Markdown
Member

To align with a future OpenSSL-imposed limit this limits the customization of KT128 and KT256 Web Cryptography algorithms to 512 bytes (same as cSHAKE).

This is an experimental Issues and PRs related to experimental features. algorithm.

@panva panva added the experimental Issues and PRs related to experimental features. label Jul 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jul 17, 2026
@panva
panva force-pushed the limit-kt-customization branch from 9568492 to 184f0c1 Compare July 17, 2026 13:48
To align with a future OpenSSL-imposed limit.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva force-pushed the limit-kt-customization branch from 184f0c1 to c2b48ee Compare July 17, 2026 13:50
@panva
panva marked this pull request as ready for review July 17, 2026 13:51
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (a27fe21) to head (c2b48ee).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64557      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         739      739              
  Lines      241698   241741      +43     
  Branches    45556    45566      +10     
==========================================
+ Hits       218129   218157      +28     
- Misses      15103    15114      +11     
- Partials     8466     8470       +4     
Files with missing lines Coverage Δ
lib/internal/crypto/webidl.js 97.96% <100.00%> (-0.01%) ⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 17, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants