doc: document sqlite parameter binding - #65089
Merged
nodejs-github-bot merged 3 commits intoAug 8, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
There was a problem hiding this comment.
Pull request overview
This PR improves the node:sqlite documentation by expanding guidance on parameter binding semantics and updating the documented type conversions/accepted bound value types to include boolean, ArrayBuffer, and SharedArrayBuffer.
Changes:
- Add a dedicated “Binding parameters” section describing anonymous (
?,?NNN) and named ($,:,@) bindings, including bare-name behavior and related configuration methods. - Update the type conversion table and bound-parameter type lists to include
boolean,ArrayBuffer, andSharedArrayBuffer. - Link statement execution methods to the new “Binding parameters” section and add reference anchors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avivkeller
approved these changes
Aug 7, 2026
trivikr
added
doc
This comment was marked as outdated.
This comment was marked as outdated.
araujogui
force-pushed
the
sqlite-parameter-binding
branch
from
August 7, 2026 20:09
e8f4715 to
af289a3
Compare
avivkeller
added
the
author ready
trivikr
reviewed
Aug 8, 2026
trivikr
removed
the
author ready
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
sqlite-parameter-binding
branch
from
August 8, 2026 13:42
216b034 to
e44f4c1
Compare
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
sqlite-parameter-binding
branch
from
August 8, 2026 13:45
e44f4c1 to
48409c5
Compare
trivikr
approved these changes
Aug 8, 2026
trivikr
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65089 ✔ Done loading data for nodejs/node/pull/65089 ----------------------------------- PR info ------------------------------------ Title doc: document sqlite parameter binding (#65089) Author Guilherme Araújo <arauujogui@gmail.com> (@araujogui) Branch araujogui:sqlite-parameter-binding -> nodejs:main Labels doc, author ready, commit-queue-squash, sqlite Commits 3 - doc: document sqlite parameter binding - doc: fix bare named parameters and bigint - doc: clarify sqlite numbered parameters Committers 1 - Guilherme Araújo <arauujogui@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65089 Refs: https://github.com/nodejs/node/pull/62001 Refs: https://github.com/nodejs/node/pull/62061 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65089 Refs: https://github.com/nodejs/node/pull/62001 Refs: https://github.com/nodejs/node/pull/62061 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Aug 2026 17:04:02 GMT ✔ Approvals: 2 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65089#pullrequestreview-4879665364 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65089#pullrequestreview-4888913502 ✘ This PR needs to wait 3 more hours to land ✘ 1 GitHub CI job(s) failed: ✘ - test-linux (ubuntu-24.04): FAILURE (https://github.com/nodejs/node/actions/runs/31260315548/job/93110033166) ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/31262749408 |
trivikr
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 114e356 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only anonymous
?binding had an example. Add a "Binding parameters" section covering the$,:, and@prefixes, bare names, and?NNN, and link to it from the execution methods.boolean,ArrayBuffer, andSharedArrayBufferwere missing from the type conversion table and the parameter type lists.Refs: #62001
Refs: #62061