deps: V8: cherry-pick 6c1b7a313b81 - #65117
Open
ulofiai wants to merge 1 commit into
Open
Conversation
Signed-off-by: ulofiai <monsterking@tutamail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64841.
Cherry-pick V8 commit 6c1b7a313b81180037c06ed4fbb45fa5f180d694.
PersistentHandles can be removed by a thread without a LocalHeap while GC iterates PersistentHandlesList. A safepoint alone therefore does not protect the linked list. Hold the existing persistent_handles_mutex_ during Iterate(), matching the upstream V8 fix.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7865180