meta: make code-and-learn PRs fast-trackable - #65122
Closed
avivkeller wants to merge 1 commit into
Closed
Conversation
Ref: https://github.com/nodejs/node-core-utils/blob/main/lib/pr_checker.js#L276 Signed-off-by: Aviv Keller <me@aviv.sh>
Collaborator
|
Review requested:
|
Contributor
|
Let's go the other way around: if you found surprising that
code-and-learn
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/nodejs/node-core-utils/blob/main/lib/pr_checker.js#L276
nodejs/TSC#1878 made me realize that
@node-core/utilsconsiders thecode-and-learnlabel to be a fast-trackable label, but our CI auto-gates those PRs and prevents them from being sent to the commit queue. With RenderATL coming up, the CI should be updated to match NCU and allow these PRs through.