Skip to content

[v24.x backport] wasm: enable JSPI - #65123

Open
guybedford wants to merge 1 commit into
nodejs:v24.x-stagingfrom
guybedford:jspi-v24
Open

[v24.x backport] wasm: enable JSPI#65123
guybedford wants to merge 1 commit into
nodejs:v24.x-stagingfrom
guybedford:jspi-v24

Conversation

@guybedford

Copy link
Copy Markdown
Contributor

This backports #59941 to Node.js 24, enabling WebAssembly Promise Integration (JSPI). While this was reverted on the v25+ lines due to V8 already enabling the feature, it is very much needed on the v24.x lines, and enabling it will significantly improve compatibility.

PR-URL: #59941
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Aug 7, 2026
PR-URL: nodejs#59941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (b881658) to head (c624972).
⚠️ Report is 805 commits behind head on v24.x-staging.

Additional details and impacted files
@@                Coverage Diff                @@
##           v24.x-staging   #65123      +/-   ##
=================================================
+ Coverage          89.92%   90.28%   +0.36%     
=================================================
  Files                686      711      +25     
  Lines             208389   228281   +19892     
  Branches           40077    43139    +3062     
=================================================
+ Hits              187387   206098   +18711     
- Misses             13238    14131     +893     
- Partials            7764     8052     +288     
Files with missing lines Coverage Δ
src/node.cc 74.48% <100.00%> (+0.04%) ⬆️

... and 305 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants