Skip to content

lib: enable web worker api by default - #65323

Open
avivkeller wants to merge 3 commits into
nodejs:mainfrom
avivkeller:web-worker-default-enable
Open

lib: enable web worker api by default#65323
avivkeller wants to merge 3 commits into
nodejs:mainfrom
avivkeller:web-worker-default-enable

Conversation

@avivkeller

Copy link
Copy Markdown
Member

cc @panva

Ref: #64894
Ref: #43583

Makes web worker support enabled by default

Signed-off-by: avivkeller <me@aviv.sh>
@avivkeller avivkeller added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (d099639) to head (67ca30a).
⚠️ Report is 134 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65323      +/-   ##
==========================================
+ Coverage   90.12%   90.14%   +0.01%     
==========================================
  Files         752      751       -1     
  Lines      251569   252536     +967     
  Branches    47264    47522     +258     
==========================================
+ Hits       226724   227644     +920     
- Misses      16188    16205      +17     
- Partials     8657     8687      +30     
Files with missing lines Coverage Δ
src/node_options.cc 79.64% <ø> (+0.08%) ⬆️
src/node_options.h 95.34% <100.00%> (ø)

... and 108 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to also add the changes entry and update the link at

node/doc/api/globals.md

Lines 1313 to 1320 in 8b9f89f

## Class: `Worker`
<!-- YAML
added: REPLACEME
-->
> Stability: 1 - Experimental. Enable this API with the
> [`--experimental-web-worker`][] CLI flag.

@avivkeller
avivkeller requested a review from aduh95 August 21, 2026 15:59
@panva panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 21, 2026
@panva panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants