Skip to content

permission: enforce addon permission in GetLinkedBinding - #65432

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:permission-linked-binding-addon
Open

permission: enforce addon permission in GetLinkedBinding#65432
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:permission-linked-binding-addon

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

process._linkedBinding() did not enforce the Addon permission check used by process.dlopen(). Apply the same permission check before resolving a linked binding, including after process.permission.drop('addon').

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (e7904d4) to head (3d2d0fa).
⚠️ Report is 372 commits behind head on main.

Files with missing lines Patch % Lines
src/node_binding.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65432      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.03%     
==========================================
  Files         746      752       +6     
  Lines      242764   252322    +9558     
  Branches    45739    47449    +1710     
==========================================
+ Hits       218848   227407    +8559     
- Misses      15426    16217     +791     
- Partials     8490     8698     +208     
Files with missing lines Coverage Δ
src/node_binding.cc 82.10% <0.00%> (-0.33%) ⬇️

... and 250 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. permission Issues and PRs related to the Permission Model labels Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants