Skip to content

chore: remove release + security categories for ESP partners#9000

Open
MattIPv4 wants to merge 1 commit into
mainfrom
MattIPv4/esp-partner-categories
Open

chore: remove release + security categories for ESP partners#9000
MattIPv4 wants to merge 1 commit into
mainfrom
MattIPv4/esp-partner-categories

Conversation

@MattIPv4

@MattIPv4 MattIPv4 commented Jul 6, 2026

Copy link
Copy Markdown
Member

Description

Coming out of today's web meeting discussion around #8995, we noticed that the partners JSON makes reference to security and release partner categories, which are not actually used in code, leading to some confusion. To make it easier to grok how the current logic + associations work as the discussion continues, this removes those unused categories for clarity.

Validation

No change in the partners rendered on the /about/partners page.

Related Issues

cc #8995 nodejs/web-team#162

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
@MattIPv4 MattIPv4 requested a review from a team as a code owner July 6, 2026 22:54
Copilot AI review requested due to automatic review settings July 6, 2026 22:54
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 6, 2026 10:54pm

Request Review

@cursor

cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Static partner metadata only; no type or rendering logic changes, and the partners page behavior is unchanged.

Overview
Updates HeroDevs and NodeSource in constants.json so their categories are only ["esp"], removing security and release labels that were never part of the typed PartnerCategory union (infrastructure | esp).

This is a data cleanup for clarity during partner-category discussions; it does not change how partners are filtered or displayed on the site.

Reviewed by Cursor Bugbot for commit 459773f. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.37%. Comparing base (4fd34e2) to head (459773f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9000      +/-   ##
==========================================
- Coverage   75.41%   75.37%   -0.05%     
==========================================
  Files          98       98              
  Lines        8636     8636              
  Branches      318      319       +1     
==========================================
- Hits         6513     6509       -4     
- Misses       2119     2123       +4     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused security and release partner categories from the partners constants JSON to align the data with the site’s actual PartnerCategory type and filtering logic, reducing confusion during partner-ranking discussions.

Changes:

  • Remove security and release from the categories arrays for affected ESP partners.
  • Ensure partner category data matches the currently supported categories used by the site ('infrastructure' | 'esp').

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bmuenzenmeyer

Copy link
Copy Markdown
Contributor

I didn't mention this in meeting @MattIPv4 but i suppose the inverse of removal is making the categories actually drive some logic.

@MattIPv4

MattIPv4 commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

I didn't mention this in meeting @MattIPv4 but i suppose the inverse of removal is making the categories actually drive some logic.

Yeh indeed, though I figure that should happen as part of the wider discussion -- I think removing for now gives us a cleaner + clearer state to work from without any confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants