chore: remove release + security categories for ESP partners#9000
chore: remove release + security categories for ESP partners#9000MattIPv4 wants to merge 1 commit into
Conversation
Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview This is a data cleanup for clarity during partner-category discussions; it does not change how partners are filtered or displayed on the site. Reviewed by Cursor Bugbot for commit 459773f. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9000 +/- ##
==========================================
- Coverage 75.41% 75.37% -0.05%
==========================================
Files 98 98
Lines 8636 8636
Branches 318 319 +1
==========================================
- Hits 6513 6509 -4
- Misses 2119 2123 +4
Partials 4 4 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
This PR removes the unused security and release partner categories from the partners constants JSON to align the data with the site’s actual PartnerCategory type and filtering logic, reducing confusion during partner-ranking discussions.
Changes:
- Remove
securityandreleasefrom thecategoriesarrays for affected ESP partners. - Ensure partner category data matches the currently supported categories used by the site (
'infrastructure' | 'esp').
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I didn't mention this in meeting @MattIPv4 but i suppose the inverse of removal is making the categories actually drive some logic. |
Yeh indeed, though I figure that should happen as part of the wider discussion -- I think removing for now gives us a cleaner + clearer state to work from without any confusion. |
Description
Coming out of today's web meeting discussion around #8995, we noticed that the partners JSON makes reference to
securityandreleasepartner categories, which are not actually used in code, leading to some confusion. To make it easier to grok how the current logic + associations work as the discussion continues, this removes those unused categories for clarity.Validation
No change in the partners rendered on the /about/partners page.
Related Issues
cc #8995 nodejs/web-team#162
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.