chore(instrodaq): deprecate digital ports in new api - #311
Open
maxleblang wants to merge 4 commits into
Open
Conversation
|
PR author is not in the allowed authors list. |
Contributor
Author
|
Work for #223 |
…ecate-digital-port-calls # Conflicts: # tests/daq/test_daq_drivers.py
…ecate-digital-port-calls
…ecate-digital-port-calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates unified
read_digitalandwrite_digitalmethods inInstroDAQand corresponding stubs inDAQDriverBase. These methods only operate on digital lines, no more digital ports. The new unifiedreadandwritemethods use these new digital methods.It's on the drivers to implement logic that maps groups of lines to ports if supported.
Closes INSTRO-502
Type of change
fix)feat)feat!/fix!)refactor)docs)chore)Verification
Tests
Checklist
feat(driver): add support for Keysight E36300)