Skip to content

chore(main): release instro-ethernetip 1.0.1 - #333

Open
nominal-bot wants to merge 1 commit into
mainfrom
release-please--branches--main--components--instro-ethernetip
Open

chore(main): release instro-ethernetip 1.0.1#333
nominal-bot wants to merge 1 commit into
mainfrom
release-please--branches--main--components--instro-ethernetip

Conversation

@nominal-bot

@nominal-bot nominal-bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

🤖 I have created a release beep boop

1.0.1 (2026-08-05)

Bug Fixes

  • nidaqmx: validate digital port width (#284) (980bc7d)

This PR was generated with Release Please. See documentation.

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@claude

claude Bot commented Jul 31, 2026

Copy link
Copy Markdown

Claude finished @nominal-bot's task in 1m 56s —— View job


Review: PR #333 (release-please version bump)

  • Gather context (release-please auto-generated version bump PR)
  • Inspect diff (manifest + CHANGELOG)
  • Run code review per custom instructions
  • Post findings

Overview: This is a mechanical release-please PR — it only touches .github/release-please-manifest.json and packages/instro-ethernetip/CHANGELOG.md, bumping the tracked version from 1.0.0 → 1.0.1. No driver code, HAL surface, or Rust source changes to review against the driver-convention/abstraction guardrails.

Finding: The new changelog entry attributes a fix(nidaqmx): validate digital port width (#284) commit to the instro-ethernetip package's release notes. Checking that commit (980bc7d), it only touched instro-daq-ni sources/tests/docs plus, incidentally, packages/instro-ethernetip/Cargo.lock (workspace lockfile churn from the dependency bump). Because release-please attributes any fix:-typed commit that touches a path under a component to that component, this pulls an unrelated NI-DAQmx bugfix into the EtherNet/IP package's changelog — confusing for anyone reading packages/instro-ethernetip/CHANGELOG.md expecting EtherNet/IP-relevant entries. Not blocking for this auto-generated PR, but worth a follow-up: consider Cargo.lock-only diffs shouldn't trigger release notes for unrelated components (e.g. via exclude-paths for the lockfile, or confirming this is expected cargo-workspace plugin behavior).

No other issues — nothing to flag on driver conventions, premature abstraction, breaking changes, tests, docstrings, or docs sync since none of those surfaces are touched here.

@nominal-bot
nominal-bot force-pushed the release-please--branches--main--components--instro-ethernetip branch 2 times, most recently from 74015b6 to 3af8ee3 Compare August 4, 2026 14:14
@nominal-bot
nominal-bot force-pushed the release-please--branches--main--components--instro-ethernetip branch from 3af8ee3 to 4b06b40 Compare August 5, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant