Bound every CI job with a timeout and name it after what it verifies - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two problems, both found while chasing a CI run that sat in progress for over an hour.
No job in this repo had a
timeout-minutes. A hung job therefore ran until GitHub's 6-hour limit rather than failing fast. Every job now carries a budget sized to what it does — 15 minutes for the console, relay, and docs builds, 25–30 for the Go suites.Every job was unnamed, so the checks list showed raw job ids.
go-testdoes vet, staticcheck,go mod tidydrift detection, coverage and its threshold — none of which the id conveys. A reader scanning a red PR could not tell which of six jobs mattered.Release and website jobs are named the same way.
Scope
CI configuration only. No source, no tests, no behavior. The same change is going out across the other five ecosystem repos, where the naming problem was worse — Spawnfile's runtime-image matrix rendered as
build (daimon, noopolis/spawnfile-runtime-daimon, 0.1.2, runtime-images/daimon, DAIMON_VERSION=0...and Simfile's suite was four anonymous shards calledtest (1)throughtest (4).