Add region to site and device metadata with automatic propagation - #35
Add region to site and device metadata with automatic propagation#35noursaidi wants to merge 1 commit into
Conversation
- Update schema/site_metadata.json to include region. - Update schema/model_system.json to include region under location. - Regenerate Java schema classes. - Update Registrar and LocalDevice to automatically copy region from site metadata to device metadata if unset during normalization. - Add unit tests in LocalDeviceTest to verify the propagation logic. Co-authored-by: noursaidi <9341216+noursaidi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change introduces a new
regionfield to the UDMI metadata schemas. It is added as a top-level property insite_metadata.jsonand as a property within thelocationobject inmodel_system.json(used for device metadata).The Registrar has been updated to automatically propagate this
regionfrom the site metadata to any device that does not have its ownregionexplicitly set. This ensures consistency across a site while allowing for per-device overrides.Java classes were regenerated to include the new fields, and unit tests were added to
LocalDeviceTest.javato verify that:PR created automatically by Jules for task 17728302459280877011 started by @noursaidi