fix(pkg): ship the files the exports maps point at - #10
Merged
Conversation
@nself/tailwind-brand exports ./css-vars.css -> ./src/css-vars.css and
./stylelint-plugin, but files listed only dist, README and LICENSE, so neither
shipped. @nself-web/ui exports ./src/index.ts with the same omission.
Invisible when pnpm symlinks a workspace package, because the whole directory
is present. It bites wherever the package is copied instead — Vercel installs
with package-import-method=copy, and the ntask web build failed with:
[postcss] ENOENT: no such file or directory,
open '@nself/tailwind-brand/css-vars.css'
Audited every package: these two were the only ones with a files array that
excluded an exported path. The rest have no files key and ship everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nself/tailwind-brandexports./css-vars.css→./src/css-vars.cssand./stylelint-plugin, butfileslisted onlydist,README.mdandLICENSE— so neither ships.@nself-web/uiexports./src/index.tswith the same omission.This is invisible when pnpm symlinks a workspace package, because the whole directory is there. It bites wherever the package is copied instead — Vercel installs with
package-import-method=copy, and the ntask web build failed with:Audited all 19 packages: these two were the only ones whose
filesarray excluded an exported path. The rest have nofileskey and ship everything.Build and typecheck clean.