Skip to content

Resolve uSID container ownership for zero-node locators - #452

Merged
watal merged 1 commit into
developfrom
fix/srv6-usid-owner-resolution
Sep 7, 2026
Merged

Resolve uSID container ownership for zero-node locators#452
watal merged 1 commit into
developfrom
fix/srv6-usid-owner-resolution

Conversation

@watal

@watal watal commented Sep 7, 2026

Copy link
Copy Markdown
Member

Description

Fix uSID container ownership resolution for zero-node locators.

Type of change

  • New feature
  • Bug fix
  • Refactoring
  • Documentation
  • Build / CI

How was this tested?

make ci

Checklist

  • make ci passes locally
  • Tests added or updated if needed
  • Documentation updated if needed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The logic change is small, directly addresses the reported bug, and is covered by updated and newly added targeted tests for the relevant edge cases.

Pull request overview

Fixes SRv6 uSID/C-SID container ownership resolution when the matched locator has zero node bits (e.g., a /32 “locator-only” advertisement), so such SIDs resolve directly to the locator owner instead of being treated as non-authoritative and falling back to adjacency-SID validation.

Changes:

  • Update SIDIndex.usidContainerOwner to treat nodeBits<=0 locators as a successful match that resolves to the matched locator owner.
  • Adjust ValidateExplicitPath test expectation to accept node-bits=0 locator ownership resolution (no adjacency-SID error).
  • Add internal tests covering node-bits=0 behavior, including single-owner, conflicting-owner, declared-structure, and nested-locator scenarios.
File summaries
File Description
pkg/table/sid_validate.go Changes uSID container ownership resolution for node-bits=0 locators to resolve directly to the locator owner.
pkg/table/sid_validate_test.go Updates explicit-path validation test to expect success when traversing a node-bits=0 locator-owned uSID container.
pkg/table/sid_validate_internal_test.go Adds focused unit tests for node-bits=0 locator ownership semantics and edge cases.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@watal
watal merged commit dceb23e into develop Sep 7, 2026
14 checks passed
@watal
watal deleted the fix/srv6-usid-owner-resolution branch September 7, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants