Skip to content

feat(nubi): add kb and memory command groups for Knowledge Base and Cortex context #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blue4209211 merged 8 commits into from
Sep 7, 2026
Merged

feat(nubi): add kb and memory command groups for Knowledge Base and Cortex context #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
984eb01
feat(nubi): add kb and memory command groups for Knowledge Base and C…
blue4209211 Sep 7, 2026
10469de
test(nubi): add unit tests for nubi kb and nubi memory subcommands
blue4209211 Sep 7, 2026
2fcce21
fix(nubi): prioritize positional account-id argument over profile def…
blue4209211 Sep 7, 2026
b9c19ee
fix(nubi): add resolveAccountIDWithPositional helper for 3-tier accou…
blue4209211 Sep 7, 2026
3a175d6
fix(nubi): use defensive pointer structs for top-level GraphQL keys t…
blue4209211 Sep 7, 2026
c004341
refactor(nubi): use dedicated kbActionResponse struct for formatted t…
blue4209211 Sep 7, 2026
bd93a1d
fix(nubi): validate limit flag > 0 in nubi memory list command
blue4209211 Sep 7, 2026
2aa8d6e
refactor(nubi): promote account-id to PersistentFlags on nubiKbCmd an…
blue4209211 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion cmd/account_id.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package cmd

import (
"fmt"
"strings"

"github.com/spf13/cobra"
"github.com/spf13/viper"
Expand All @@ -11,7 +12,10 @@ import (
// prefers an explicit --account-id flag, falls back to the configured
// profile via viper, and returns an error if neither is set.
func resolveAccountID(cmd *cobra.Command) (string, error) {
accountID, _ := cmd.Flags().GetString("account-id")
accountID, err := cmd.Flags().GetString("account-id")
if err != nil {
accountID = ""
}
if accountID == "" {
accountID = viper.GetString("account-id")
}
Comment thread
blue4209211 marked this conversation as resolved.
Expand All @@ -20,3 +24,23 @@ func resolveAccountID(cmd *cobra.Command) (string, error) {
}
return accountID, nil
}

// resolveAccountIDWithPositional returns the account-id prioritizing an explicit
// --account-id flag (if set), followed by a positional argument, and falling
// back to profile config via viper.
func resolveAccountIDWithPositional(cmd *cobra.Command, args []string) (string, error) {
if cmd.Flags().Changed("account-id") {
flagVal, err := cmd.Flags().GetString("account-id")
if err == nil && strings.TrimSpace(flagVal) != "" {
return strings.TrimSpace(flagVal), nil
}
}
Comment thread
blue4209211 marked this conversation as resolved.
if len(args) > 0 && strings.TrimSpace(args[0]) != "" {
return strings.TrimSpace(args[0]), nil
}
accountID, err := resolveAccountID(cmd)
if err != nil {
return "", fmt.Errorf("resolving account ID: %w", err)
}
return accountID, nil
}
Loading